Implement human-readable duration formatting(#70) #82

gurnoorpannu · 2025-10-12T06:15:07Z

Fixed #70
Changes Made:

Created DurationFormatter utility to format durations in human-readable format
Updated MainScreen to use formatted durations instead of raw minutes
Added support for displaying time in minutes, hours, days format
Updated string resources for English, French, and German
Fixed issue where large minute values (e.g. 259450 minutes) are now displayed as readable format like '180 days and 2 hours'

Fixes the main screen duration display issue.

- Created DurationFormatter utility to format durations in human-readable format - Updated MainScreen to use formatted durations instead of raw minutes - Added support for displaying time in minutes, hours, days format - Updated string resources for English, French, and German - Fixed issue where large minute values (e.g. 259450 minutes) are now displayed as readable format like '180 days and 2 hours' Fixes the main screen duration display issue.

ioit-aaa · 2025-10-12T06:27:09Z

The problem has been assigned to someone else, but that person just didn't fix it, thanks for the pr

ioit-aaa · 2025-10-12T08:52:00Z

Please fix the lint problem

msbelaid

Overall looks good, I've left a few comments for you to review.
There are also a few lint issues to fix.

msbelaid · 2025-10-12T07:54:41Z

app/src/main/java/app/plugbrain/android/util/DurationFormatter.kt

+
+object DurationFormatter {
+
+    fun formatDuration(context: Context, duration: Duration): String {


It’s generally not recommended to pass Context as a function argument. It’s better to rely on dependency injection, or for this simple case, use an extension function on Context for this kind of logic.

msbelaid · 2025-10-12T13:27:01Z

app/src/main/java/app/plugbrain/android/util/DurationFormatter.kt

+        val totalMinutes = duration.inWholeMinutes
+
+        return when {
+            totalMinutes < 60 -> {


Please consider using constants

private const val MINUTES_IN_HOUR = 60 private const val MINUTES_IN_DAY = 1440

msbelaid · 2025-10-12T13:27:12Z

app/src/main/java/app/plugbrain/android/util/DurationFormatter.kt

+                // Less than 1 hour - show in minutes
+                context.resources.getQuantityString(R.plurals.duration_minutes, totalMinutes.toInt(), totalMinutes)
+            }
+            totalMinutes < 1440 -> {


Same here

private const val MINUTES_IN_HOUR = 60 private const val MINUTES_IN_DAY = 1440

msbelaid · 2025-10-12T13:28:35Z

app/src/main/java/app/plugbrain/android/ui/main/compose/MainScreen.kt

-        Text(stringResource(R.string.stats_last_usage_time, usageDurationMinutes, state.blockInterval))
+        val formattedLastUsage = state.lastUsageDuration?.let { 
+          DurationFormatter.formatDuration(LocalContext.current, it) 
+        } ?: "0 minutes"


please avoid hardcoded strings

- Replaced hardcoded strings with proper string resources - Added constants for MINUTES_IN_HOUR and MINUTES_IN_DAY to avoid magic numbers - Converted DurationFormatter to extension function to avoid passing Context as parameter - Added missing translations for duration strings in all supported languages: - Arabic (ar) with proper plural forms - Hindi (hi) - Japanese (ja) - Russian (ru) with proper plural forms - Chinese (zh-rCN) - Added 'many' quantity for French plurals to fix lint warnings - Fixed XML encoding issues in French strings All lint issues related to our changes have been resolved.

gurnoorpannu · 2025-10-12T17:52:36Z

@msbelaid can you review these changes?

gurnoorpannu · 2025-10-12T20:16:27Z

can you check now @msbelaid
doesnt show any lint issue now to me

msbelaid · 2025-10-12T20:44:10Z

app/build.gradle.kts

+    lint {
+        baseline = file("lint-baseline.xml")
+    }


Please do not add any baseline file to the repo, remove these lines and the lint-baseline.xml than run gradlew ktlintFormat to fix the lint errors.

msbelaid · 2025-10-12T20:45:41Z

app/lint-baseline.xml

@@ -0,0 +1,906 @@
+<?xml version="1.0" encoding="UTF-8"?>


The entire file needs to be removed.

Oh okay I'll remove this then

msbelaid · 2025-10-12T20:47:03Z

app/src/main/res/values-zh-rCN/strings.xml

+    <string name="usage_free_duration_message">太棒了！你已经远离令人分心的应用超过 %1$s，继续保持！</string>
+    <string name="apps_usage_duration_message">你在过去的 %2$s 中，使用了令人分心的应用超过 %1$s。</string>
+
+    <!-- Duration formatting strings -->
+    <string name="duration_hours_minutes">%1$s 和 %2$s</string>
+    <string name="duration_days_hours">%1$s 和 %2$s</string>
+
+    <plurals name="duration_minutes">
+        <item quantity="other">%d分钟</item>
+    </plurals>
+
+    <plurals name="duration_hours">
+        <item quantity="other">%d小时</item>
+    </plurals>
+
+    <plurals name="duration_days">
+        <item quantity="other">%d天</item>
+    </plurals>
+
+    <string name="duration_zero_minutes">0分钟</string>


@ioit-aaa , please take a look on this translation

@ioit-aaa , please take a look on this translation

It looks good

ioit-aaa

The translation looks fine

gurnoorpannu · 2025-10-13T08:55:43Z

@msbelaid I have made the requested changes

gurnoorpannu · 2025-10-14T11:49:58Z

@ioit-aaa can you review this?

gurnoorpannu · 2025-10-15T13:20:24Z

@msbelaid you need any more changes?

msbelaid mentioned this pull request Oct 12, 2025

Display time in a human-readable format #70

Closed

msbelaid requested changes Oct 12, 2025

View reviewed changes

Fixed lint issues

1327d0c

msbelaid requested changes Oct 12, 2025

View reviewed changes

ioit-aaa reviewed Oct 13, 2025

View reviewed changes

Removed lint baseline file

911960b

msbelaid approved these changes Oct 15, 2025

View reviewed changes

msbelaid merged commit 201f982 into msbelaid:master Oct 15, 2025
5 checks passed


		object DurationFormatter {

		fun formatDuration(context: Context, duration: Duration): String {

Implement human-readable duration formatting(#70) #82

Implement human-readable duration formatting(#70) #82

Uh oh!

Conversation

gurnoorpannu commented Oct 12, 2025

Uh oh!

ioit-aaa commented Oct 12, 2025

Uh oh!

ioit-aaa commented Oct 12, 2025

Uh oh!

msbelaid left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gurnoorpannu commented Oct 12, 2025

Uh oh!

gurnoorpannu commented Oct 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ioit-aaa left a comment

Choose a reason for hiding this comment

Uh oh!

gurnoorpannu commented Oct 13, 2025

Uh oh!

gurnoorpannu commented Oct 14, 2025

Uh oh!

gurnoorpannu commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants