Connection: Add option to specify keep-alive behaviour on connect.#192
Open
peterkooijmans wants to merge 3 commits intomscdex:masterfrom
Open
Connection: Add option to specify keep-alive behaviour on connect.#192peterkooijmans wants to merge 3 commits intomscdex:masterfrom
peterkooijmans wants to merge 3 commits intomscdex:masterfrom
Conversation
|
Is there any chance of this PR to get merged? |
|
This should be merged. It's unable to make the connection when setSocketAlive is true for GoDaddy FTP too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At one of our customers with a DELL Sonic firewall, the FTP connection would be dropped when keep-alives are enabled. This pull request adds an option to specify the keep-alive behaviour of the FTP connection and defaults to the safe option of disabling it.