Skip to content

Added support for numeric parameters in Client#prepare() #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krizalys wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added support for numeric parameters in Client#prepare() #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a1a66a
Updated unit test
krizalys Sep 2, 2017
b624206
Added support for numeric parameters in Client#prepare()
krizalys Sep 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/Client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,9 @@ Client.prototype._format_value = function(v) {
for (var i = 0, len = v.length; i < len; ++i)
r.push(this._format_value(v[i]));
return r.join(',');
} else if (v !== null && v !== undefined)
} else if (Object.getPrototypeOf(v) == Number.prototype)
return v.toString();
else if (v !== null && v !== undefined)
return "'" + Client.escape(v + '') + "'";

return 'NULL';
Expand Down
32 changes: 16 additions & 16 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,22 @@ var tests = [
run: function() {
var client = new Client();
var fn;
fn = client.prepare("SELECT * FROM foo WHERE id = '123'");
assert.strictEqual(fn({ id: 456 }),
"SELECT * FROM foo WHERE id = '123'");
fn = client.prepare("SELECT * FROM foo WHERE id = :id");
assert.strictEqual(fn({ id: 123 }),
"SELECT * FROM foo WHERE id = '123'");
assert.strictEqual(fn({ id: 456 }),
"SELECT * FROM foo WHERE id = '456'");
fn = client.prepare("SELECT * FROM foo WHERE id = ?");
assert.strictEqual(fn([123]),
"SELECT * FROM foo WHERE id = '123'");
assert.strictEqual(fn([456]),
"SELECT * FROM foo WHERE id = '456'");
fn = client.prepare("SELECT * FROM foo WHERE id = :0 AND name = :1");
assert.strictEqual(fn(['123', 'baz']),
"SELECT * FROM foo WHERE id = '123' AND name = 'baz'");
fn = client.prepare("SELECT * FROM foo WHERE id = 'ABC' LIMIT 123");
assert.strictEqual(fn({ id: 'DEF', limit: 456 }),
"SELECT * FROM foo WHERE id = 'ABC' LIMIT 123");
fn = client.prepare("SELECT * FROM foo WHERE id = :id LIMIT :limit");
assert.strictEqual(fn({ id: 'ABC', limit: 123 }),
"SELECT * FROM foo WHERE id = 'ABC' LIMIT 123");
assert.strictEqual(fn({ id: 'DEF', limit: 456 }),
"SELECT * FROM foo WHERE id = 'DEF' LIMIT 456");
fn = client.prepare("SELECT * FROM foo WHERE id = ? LIMIT ?");
assert.strictEqual(fn(['ABC', 123]),
"SELECT * FROM foo WHERE id = 'ABC' LIMIT 123");
assert.strictEqual(fn(['DEF', 456]),
"SELECT * FROM foo WHERE id = 'DEF' LIMIT 456");
fn = client.prepare("SELECT * FROM foo WHERE id = :0 AND name = :1 LIMIT :2");
assert.strictEqual(fn(['ABC', 'baz', 123]),
"SELECT * FROM foo WHERE id = 'ABC' AND name = 'baz' LIMIT 123");

// Edge cases
fn = client.prepare("SELECT * FROM foo WHERE id = :id"
Expand Down