Fix pathconv issues related to relative paths in path lists#67
Closed
ReinhardBiegelIntech wants to merge 5 commits intomsys2:mainfrom
Closed
Fix pathconv issues related to relative paths in path lists#67ReinhardBiegelIntech wants to merge 5 commits intomsys2:mainfrom
ReinhardBiegelIntech wants to merge 5 commits intomsys2:mainfrom
Conversation
Author
|
@dscho Could you please have a look at this? |
Suggested-by: Richard Copley <buster@buster.me.uk>
Author
|
Closing together with msys2/msys2-runtime#213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if I got it right, but it seems that the fix proposed in msys2/msys2-runtime#212 doesn't handle values (e.g. potential path lists) being assigned to a process local environment variable, like in a call
VARNAME=.:../foo ./my-script.sh.This tries to add an additional check to cover this case.
@dscho What's your opinion on that?