vacuum propagation rework #27
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Athozus
reviewed
Apr 13, 2024
| }) | ||
| --]] | ||
|
|
||
| minetest.register_chatcommand("test", { |
Member
There was a problem hiding this comment.
Is this debug command supposed to be there 😉
| local area = VoxelArea:new({MinEdge=e1, MaxEdge=e2}) | ||
| local node_ids = manip:get_data() | ||
|
|
||
| for z=ipos1.z, ipos2.z do |
Member
There was a problem hiding this comment.
A bit scared by those nested fors, but it looks like that the limits are very close to each other.
Just wondering why using this syntax because after you are adding/subtracting 1 coordinate-by-coordinate.
Member
Author
|
@Athozus this is still a work-in-progress PR (or draft in github terms) the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance tests