Open
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
commented
Feb 21, 2025
|
|
||
| This package implements a simple stream router for the multistream-select protocol. | ||
| The protocol is defined [here](https://github.com/multiformats/multistream-select). | ||
| This package implements a simple stream router for the [multistream-select protocol](https://github.com/multiformats/multistream-select). |
Author
There was a problem hiding this comment.
This isn't technically a spelling error, but it's easy enough to look for other things at the same time, the rule is:
Do not use (click) here links
For more information, see:
| } | ||
|
|
||
| func delitmWriteAll(w io.Writer, messages ...[]byte) error { | ||
| func delimWriteAll(w io.Writer, messages ...[]byte) error { |
Author
There was a problem hiding this comment.
This is based on it calling delimWrite below...
| } | ||
|
|
||
| func TestNegotiatThenWriteFail(t *testing.T) { | ||
| func TestNegotiateThenWriteFail(t *testing.T) { |
Author
There was a problem hiding this comment.
My understanding is that changes to go test names are fairly harmless even though they're public functions...
Comment on lines
+756
to
+757
| delimitedProtocolID := make([]byte, buf.Len()) | ||
| copy(delimitedProtocolID, buf.Bytes()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/go-multistream/actions/runs/13458098141#summary-37606510208
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/go-multistream/actions/runs/13458098343#summary-37606511331