refactor(lazyClientConn): Use synctest friendly once func#120
Merged
refactor(lazyClientConn): Use synctest friendly once func#120
Conversation
MarcoPolo
force-pushed
the
marco/synctest-friendly-oncefunc
branch
from
9577191 to
f8b2fec
Compare
sukunrt
approved these changes
Jun 3, 2025
lazyClient.go
Outdated
| // onceFunc is a sync.Once that can be used by synctest. | ||
| // For the Multistream, it is a bit better than sync.Once because it doesn't | ||
| // spin when acquiring the lock. | ||
| type onceFunc struct { |
Member
There was a problem hiding this comment.
NIT:
Suggested change
| type onceFunc struct { | |
| type once struct { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the sync.Once usage to a synctest friendly once version. More context on synctest here: https://go.dev/blog/synctest.
synctest doesn't consider code blocked by a mutex as "durably blocked." This makes sense for the common case where a mutex protects some critical section of code that runs quickly. In multistream's case the protected section of a mutex does IO (it finishes the handshake). This would mean that you would end up deadlocked in a synctest bubble because one goroutine would be waiting to acquire the lock, but the goroutine that would free the lock wouldn't be able to make progress because no network IO or time would happen.
With this change basichost works with synctest.