feat!: BlockEncoder optional promise for encode/decode #305
Open
mabels wants to merge 2 commits intomultiformats:masterfrom
Open
feat!: BlockEncoder optional promise for encode/decode #305mabels wants to merge 2 commits intomultiformats:masterfrom
mabels wants to merge 2 commits intomultiformats:masterfrom
Conversation
mabels
commented
Jul 30, 2024
methods.
Why we need that:
https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto
To enable the async a breaking change to createUnsafe is
required.
The existing signature is not able to pass a promise.
Therefore the tests need to change.
For me, measuring the blast radius of the change is impossible.
If the blast radius is too big then there is still the possibility to
create a new method createUnsafeAsync and throw an error
in the createUnsafe if the decode sends a promise.
rvagg
reviewed
Jul 30, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.