fix!: identity hash is Hasher<"identity", 0>#314
Open
Conversation
rvagg
approved these changes
Dec 3, 2024
Author
|
@achingbrain any qualms against this one? |
achingbrain
reviewed
Feb 4, 2025
achingbrain
reviewed
Feb 5, 2025
achingbrain
approved these changes
Feb 5, 2025
Co-authored-by: Alex Potsides <alex@achingbrain.net>
Member
|
With hindsight E.g. // identity.ts
import type { SyncMultihashHasher } from './interface.js'
// ... other code
export const identity: SyncMultihashHasher<0x00> = { code, name, encode, digest }One problem is that One (breaking) solution would be remove the Alternatively (non-breaking) we can add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change because return type no longer supports sync (aligns with other hashers)
Fixes #313