Merged
Conversation
This was referenced Feb 3, 2023
Member
|
Sorry for my ignorance on some of this, but is this intended to be used in CIDs, and is the block format the IPNS protobuf format? |
Member
Author
|
@rvagg correct. Block identified by CID with this codec can be parsed by following the protobuf from the IPNS spec: https://github.com/ipfs/specs/blob/main/ipns/IPNS.md#record-serialization-format |
rvagg
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes adding
ipns-record, like we already have one forlibp2p-peer-record. ipfs/specs#369Rationale / potential uses:
ipns(0xe5) code which would be invalid, as it indicates IPNS "namespace"./ipns/{id}?format=carcould return a CAR withipns-recordas an additional block.