Conversation
# Should the property test be `arb` feature-gated? I inclinde to *no* because the tests are not feature-specific and it's a good thing `cargo t` fails until like `--features` is added. # `#[cfg(any(test, feature = "arb"))]` I considered this approach but having some experience with it shows that syncing versions between the feature and dev.dependencies is a nuisance. Being more naive it doesn't add much (only working `cargo t` but it works smoothly adding the feature).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to use
impl Arbitrarydownstream in my (utilities) tests.Should the property tests be
arbfeature-gated?I inclinde to no because the tests are not feature-specific and it's a good thing
cargo tfails until like--featuresis added.#[cfg(any(test, feature = "arb"))]I considered this approach but having some experience with it shows that syncing versions between the feature and dev.dependencies is a nuisance. Being more naive it doesn't add much (only the working
cargo tbut it works smoothly when the feature is added).