feat(multihash): update MSRV to 1.60.0 and use new syntax for cargo features#258
feat(multihash): update MSRV to 1.60.0 and use new syntax for cargo features#258koushiro wants to merge 3 commits intomultiformats:masterfrom koushiro:some-improvements
Conversation
…eatures some trivials: - use sha1 instead of sha-1 dependency - update strobe-rs v0.7.0 ==> v0.8.1 - update serde-big-array v0.3.2 ==> v0.4.1
…the `resolvers = "2"` to workspace
vmx
left a comment
There was a problem hiding this comment.
Is the resolver = 2 needed in the workspace?
Moving to a new edition is usually a breaking change, hence it wasn't done for the derive crate yet, as I didn't want to do a breaking change release, just for upgrading the edition.
Also bumping the MSRV usually is a breaking change. I'd like to keep doing breaking releases to a minimum. Is there a way doing the crate updates without bumping the MSRV (or was bumping it the whole point?)?
The resolver is a global setting for a workspace, and the setting is ignored in dependencies. The setting is only honored for the top-level package of the workspace. see https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html#details for details.
I know the upgrading the edition and MSRV are breaking changes, so you can merge this PR next time you need to upgrade the minor version. |
|
I think most of this happened in #272 now. |
and some trivial things:
sha1instead ofsha-1dependencystrobe-rsv0.7.0 ==> v0.8.1serde-big-arrayv0.3.2 ==> v0.4.1multihash-deriveto edition 2021resolver = "2"to workspace