Skip to content

fix: fix the misuse of unbuffered os.Signal channel #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fivecut wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fix the misuse of unbuffered os.Signal channel #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/proxy/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ func startWebServer(
}

func waitForServerShutdown(httpServer *http.Server, closableComponents *data.ClosableComponentsHandler) {
quit := make(chan os.Signal)
quit := make(chan os.Signal, 1)
Copy link

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! Using a buffered channel with capacity 1 prevents potential signal loss. The Go documentation recommends buffered channels for signal.Notify to ensure signals are not dropped if the receiver is not immediately ready.

Suggested change
quit := make(chan os.Signal, 1)
quit := make(chan os.Signal, 1) // Buffered channel with capacity 1 to prevent signal loss

Copilot uses AI. Check for mistakes.
signal.Notify(quit, os.Interrupt, os.Kill)
<-quit

Expand Down