Conversation
V1.7 to asnyc v3 14 feb
merge V1.7 to async v3
…todos refactor output in case of error for async callback and empty function name check
sasurobert
reviewed
Jul 30, 2025
| return nil, vmhost.ErrNilEnableEpochsHandler | ||
| } | ||
| err := core.CheckHandlerCompatibility(hostParameters.EnableEpochsHandler, allFlags) | ||
| err := core.CheckHandlerCompatibility(hostParameters.EnableEpochsHandler, []core.EnableEpochFlag{}) |
| returnCode := context.resolveReturnCodeFromError(err) | ||
| returnMessage := context.resolveReturnMessageFromError(err) | ||
|
|
||
| if context.host.EnableEpochsHandler().IsFlagEnabled(vmhost.AsyncV3Flag) && callType == vm.AsynchronousCallBack { |
Contributor
There was a problem hiding this comment.
I do not think this is ok, also you should check whether the async call was of type v3.
| } | ||
|
|
||
| func (host *vmHost) checkValidFunctionName(name string) error { | ||
| if name == "" { |
Contributor
There was a problem hiding this comment.
I think we have a function validator when we deploy the contracts. Use that.
| // CreateAsyncV3Call VMHooks implementation. | ||
| // @autogenerate(VMHooks) | ||
| func (context *VMHooksImpl) CreateAsyncV3Call( | ||
| destOffset executor.MemPtr, |
Contributor
There was a problem hiding this comment.
everything should be managed. not PTR. Or have the same call with managed buggers as well.
| gas int64, | ||
| extraGasForCallback int64, | ||
| ) int32 { | ||
| calledSCAddress, err := context.MemLoad(destOffset, vmhost.AddressLen) |
Contributor
There was a problem hiding this comment.
gas should be used before making any kind of load.
| CallbackClosure []byte | ||
|
|
||
| IsBuiltinFunctionCall bool | ||
| IsAsyncV3 bool |
Contributor
There was a problem hiding this comment.
this is not backward compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactors, callback order, gas lock, results accumulation