Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/supernova #978 +/- ##
================================================
+ Coverage 36.23% 37.64% +1.41%
================================================
Files 87 87
Lines 20589 17573 -3016
================================================
- Hits 7460 6616 -844
+ Misses 12462 10287 -2175
- Partials 667 670 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // VerifyAggregatedSig verifies aggregated signature of BLS MultiSig | ||
| func (b *bls) VerifyAggregatedSig(pubKeysSigners [][]byte, message []byte, aggSig []byte) error { | ||
| return b.multiSigner.VerifyAggregatedSig(pubKeysSigners, message, aggSig) | ||
| pubKeys, err := b.convertBytesToPubKeys(pubKeysSigners) |
There was a problem hiding this comment.
this should behave as before, until now this convert was done in crypto multi signer
There was a problem hiding this comment.
we can analyse to cache here pubkeys and avoid conversion (which takes quite some time ~60ms)
There was a problem hiding this comment.
yes... it will add some overhead here... the 60 ms...
| github.com/mitchellh/mapstructure v1.5.0 | ||
| github.com/multiversx/mx-chain-core-go v1.4.0 | ||
| github.com/multiversx/mx-chain-crypto-go v1.3.0 | ||
| github.com/multiversx/mx-chain-crypto-go v1.3.1-0.20260127130843-3c6c4667127e |
| // VerifyAggregatedSig verifies aggregated signature of BLS MultiSig | ||
| func (b *bls) VerifyAggregatedSig(pubKeysSigners [][]byte, message []byte, aggSig []byte) error { | ||
| return b.multiSigner.VerifyAggregatedSig(pubKeysSigners, message, aggSig) | ||
| pubKeys, err := b.convertBytesToPubKeys(pubKeysSigners) |
There was a problem hiding this comment.
yes... it will add some overhead here... the 60 ms...
|
This will be on hold for now. Changed multiversx/mx-chain-crypto-go#53 to add new methods for the signing methods. |
2 participants
No description provided.