5.5.1

[mgavrila]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @mgavrila, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers version 5.5.1 of the SDK, focusing on providing more granular control and flexibility during the transaction signing process. It introduces advanced options for signTransactions, allowing developers to customize guardian behavior and inject custom logic via a callback. These changes empower dApps with greater control over the user experience and transaction flow, while also exposing a new action to manage the signing UI state.

Highlights

• Enhanced Transaction Signing Options: The signTransactions method now accepts an optional options parameter, introducing skipGuardian to bypass guardian validation and a callback function for custom processing of signed transactions before guardian approval.
• New UI Control Action: A new action, setIsSigningUiEnabled, has been exposed to allow programmatic control over the visibility and state of the signing UI.
• Version Update and Documentation: The SDK version has been bumped to 5.5.1, and the CHANGELOG.md and README.md files have been updated to reflect these new features and their usage.
• Provider Strategy Adaptations: All relevant provider strategies (CrossWindow, Extension, Iframe, Ledger, WalletConnect, Webview) have been updated to accommodate the new SignTransactionsOptionsType in their signTransactions methods, ensuring consistent behavior across different integration methods.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces new SignTransactionsOptionsType with skipGuardian and callback options to the signTransactions method across various provider strategies, allowing for post-signing processing before guardian validation. The CHANGELOG.md and README.md are updated to reflect these changes and the version bump to 5.5.1. However, the review comments highlight that the CrossWindowProviderStrategy explicitly removes the guardTransactions call, which would disable 2FA/guardian support for this provider and requires clarification and documentation. Additionally, the skipGuardian option is not correctly passed to the guardTransactions helper function in src/providers/strategies/helpers/signTransactions/signTransactions.ts, preventing it from functioning as intended for providers that rely on this helper.