Upgrade devnet contract

[arhtudormorar]

Adapt to contract responding with miliseconds

[gemini-code-assist]

Summary of Changes

Hello @arhtudormorar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the devnet contract and ensuring the frontend application remains compatible with the new contract's behavior. The core change involves adapting the application to handle time durations in milliseconds, as dictated by the updated contract, alongside a new contract deployment and ABI structure.

Highlights

• Frontend Adaptation: The PingPongComponent has been updated to correctly interpret time remaining from the backend, converting milliseconds to seconds for display and logic.
• Devnet Contract Update: The contractAddress in the devnet configuration has been updated, pointing to a new deployment of the Ping Pong smart contract.
• Contract ABI Changes: The ping-pong.abi.json reflects significant updates, including changes to the build environment, renaming of the duration_in_seconds parameter to duration_in_millis (indicating the contract now expects time in milliseconds), and the addition of an upgradeConstructor definition.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request upgrades the devnet contract and adapts the frontend to handle time values in milliseconds instead of seconds, as returned by the updated contract. The changes include updating the contract address, the ABI file, and modifying the PingPongComponent to correctly process the new time format. The implementation looks correct and addresses the change in the contract's response. I have one suggestion in PingPongComponent.tsx to improve the readability of the time conversion logic.

[gemini-code-assist]

The ternary expression for calculating secondsRemaining can be simplified for better readability. Since both null and undefined for msRemaining are handled identically downstream, we can use a more direct != null check and explicitly return null when msRemaining is either null or undefined.

Suggested change

	const secondsRemaining =
	msRemaining == null
	? msRemaining
	: Math.max(0, Math.floor(msRemaining / 1000));
	const secondsRemaining =
	msRemaining != null
	? Math.max(0, Math.floor(msRemaining / 1000))
	: null;