extend to next note #27456

Ash-86 · 2025-03-30T17:39:15Z

Proposal to add a "extend to next note" action.

notes within range selection extend up to next note.
last note continues to be extended beyond selection box until next note is found. in this case, selection box extended too.
if there isn't any note till end of score, the selected note will be extended to end of score

bug: Applying on triplets seems to erase the triplet number and bracket above the notes. While execution seems correct, undoing displays strange behaviour.

demo11.mp4

triplets example with undoing going bad:

demo2.mp4

src/appshell/view/appmenumodel.cpp

src/notation/inotationinteraction.h

src/notation/internal/notationactioncontroller.cpp

src/notation/internal/notationinteraction.h

src/notation/internal/notationuiactions.cpp

src/notation/tests/mocks/notationinteractionmock.h

XiaoMigros · 2025-03-31T23:17:09Z

Seems very out of place in the tools menu. Perhaps better as a configurable shortcut? And maybe add an option to extend to previous notes as well as next ones

Ash-86 · 2025-04-30T21:07:20Z

@cbjeukendrup any chance i could get some feedback on this?

cbjeukendrup

A couple of comments:

cbjeukendrup · 2025-05-01T01:07:32Z

src/engraving/dom/cmd.cpp

+        if (el->isNote() || el->isChord()) {
+            Note* on = toNote(el);


This is an error if !el->isNote() but el->isChord()

src/engraving/dom/cmd.cpp

Tantacrul · 2025-05-01T12:08:10Z

This is a very interesting little idea. For sure, it would not be a capability found in the main menu bar... but I assume that's placement is placeholder for now.

Potential places it could go:

It could be a single-action tool placed in the 'Customise Toolbar' popover, which means users could potentially add it to their top bar if they like. We could create a little icon for it if @bkunda and others agreed it is nice to have. (It would definitely need a shortcut too.)
Since it's not a new function, it could simply only live in the context menu (for selected notes) and also as a new shortcut.

FWIW: It should definitely not exist in the properties panel because it's a notation action and not a property.

src/engraving/dom/cmd.cpp

Tantacrul · 2025-05-02T09:30:33Z

@Ash-86 - I'm happy to test this and suggest the best UX. Can you fix the issue with the MacOS build and then I can provide any needed assets and perhaps a very small little design spec too? Once we're happy with it, we'll merge.

Cheers!

Jojo-Schmitz · 2025-05-02T09:33:29Z

Seems the macOS build failure is outside to what @Ash-86 can fix

cbjeukendrup · 2025-05-02T09:38:22Z

Yes, that's the same macOS failure as we're seeing all the time these days. I have a PR to fix it, waiting for review. #27910

Tantacrul · 2025-05-02T09:51:24Z

Ah, OK. cool. We'll await the fix on our end.

Ash-86 · 2025-05-02T14:34:54Z

@Tantacrul great! I'll be waiting for your input. It looks like the macOS build test has passed.

Ash-86 · 2025-05-04T00:45:02Z

I fixed a few issues with selecting extended notes in list selection, as well as the last measure issue. I also removed the menu item, so anyone who wants to test this can now use the shortcut Alt+W (though you might have a better one).
The triplet issue is still present, however. Could someone point out how to add a chord to a tuplet in a way that ensures undoing doesn't corrupt the score?

sammik · 2025-05-04T17:46:19Z

Could someone point out how to add a chord to a tuplet in a way that ensures undoing doesn't corrupt the score?

I would look, how it is done by "Tie" command in note input mode.

sammik · 2025-05-04T18:13:25Z

One thing, which one is intended, upper one?

Ash-86 · 2025-05-04T19:15:26Z

One thing, which one is intended, upper one?

The function uses changeCRlen, so upper one.

zacjansheski · 2025-12-22T19:51:39Z

On a range selection with a grace note it skips a measure

video1267587921.mp4

Ash-86 · 2025-12-23T22:15:06Z

@zacjansheski The grace notes issue should be resolved now. Would you mind giving it another try?

zacjansheski · 2026-01-02T23:07:22Z

Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved

Ash-86 · 2026-01-03T00:19:48Z

@zacjansheski @cbjeukendrup Before we merge, I wanted to suggest a feature: extending notes from partially selected chords individually instead of always extending the whole chord. This would align with the behavior of R (and soon T) on list selection. I've already made the changes and can push them next week. What are your thoughts?"

cbjeukendrup · 2026-01-03T00:55:18Z

To me that sounds sensible (especially considering that if the user does want the entire chord to be affected, that's now perhaps easy enough with the "double click to select whole chord" feature).

It turns out GitHub wants you to do another rebase... (it should be trivial because I did not much more than moving files which Git usually handles well).

Jojo-Schmitz · 2026-01-07T09:48:07Z

rebase indeed is dead easy, no conflicts to resolve at all

Jojo@DodekaCore MINGW64 ~/Documents/GitHub/MuseScore (pr/27456)
$ git pull --rebase upstream master
From https://github.com/musescore/MuseScore
 * branch                  master     -> FETCH_HEAD
Successfully rebased and updated refs/heads/pr/27456.

Additional step needed is git push -f (which I can't do)

Ash-86 · 2026-01-08T18:30:54Z

Cool @cbjeukendrup, rebased and pushed new commit with the new changes.

zacjansheski · 2026-01-09T21:02:20Z

Found a crash when using extend to next note on a note with a laissez vibrer

video1670667244.mp4

MacOS crash log:

Untitled-1.txt

Ash-86 force-pushed the extend-to-next-note branch 2 times, most recently from 45224d6 to 2a4eac6 Compare March 30, 2025 17:54