Skip to content

Conversation

@pyonpyoco
Copy link

Resolves: #31410

This PR fixes the selection behavior where chord symbols and Roman numeral analysis were selected together when using click / Shift+click.

After this change, chord symbols, Roman numerals, and Nashville notation are treated as separate selectable elements for default click and Shift+click operations, while keeping the existing selection model otherwise unchanged.

Demo

2025-12-20.161633.mp4
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Copy link
Contributor

@XiaoMigros XiaoMigros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems easier to add a subtype property to harmony elements (equal to harmonytype). That reduces special logic and would allow for special selections in the select/more menu. See #20850 for an example of how to implement it (and what other methods are needed).

@pyonpyoco pyonpyoco force-pushed the fix/select-similar-harmony-subtype branch from 5031a7e to 43cf0f7 Compare December 24, 2025 05:52
@pyonpyoco
Copy link
Author

Thanks for the suggestion!
I added a subtype to the Harmony class and confirmed that this makes Shift+click and Select More behave consistently when selecting by subtype.
I didn’t add subtypeUserName() for now, since the UI already distinguishes the three harmony types correctly and I didn’t observe any issues. I kept the change minimal, but I’m happy to adjust this if needed.

2025-12-24.143938.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shift clicking chord symbols also also selects roman numerals and vice versa.

3 participants