Skip to content

Conversation

@Reedbeta
Copy link
Contributor

@Reedbeta Reedbeta commented Dec 24, 2025

Resolves: #31567

The problem was that repitch left nval.tpc1 set to invalid, and then we'd set tpc1 directly from the MIDI pitch, leading to inconsistent values for tpc1 and tpc2. Instead, we should set tpc1 by transposing tpc2 if it's valid, and only use the MIDI pitch if both are invalid.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@Reedbeta Reedbeta force-pushed the pr/fix-repitch-respell-issue branch from 8af5c60 to d819cfd Compare December 24, 2025 07:15
@cbjeukendrup
Copy link
Member

It seems that this also resolves #26681 / #31477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After repitch, accidentals are re-spelled on copy/paste

3 participants