UI. Popups. Fixed resolve parent window #31606
Open
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audacity uses a QML WindowController in dialogs, and if we draw a button that calls our popup inside such a controller, the popup appears behind the main dialog. The solution is to look for our window class and return it, instead of the window from the WindowController.
…or setup if the second monitor is below the first, then the global point was on the second monitor
Eism
force-pushed
the
ui_popups_resolve_parent_fix
branch
from
f2e0e47 to
90b61e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: audacity/audacity#9990
+ fixed an issue with opening the menus from statusbar in a multi-monitor setup