Fix CMake/GCC/clang warnings #284
Conversation
|
It seems the compatibility with |
|
My original intention was to keep support for older CMake versions like 3.5. However, that is still going to conflict with very recent CMake v4.x releases, as you see in the CI failures. I can try bumping the minimum requirement to CMake 3.10. BTW, One of these errors comes from |
Otherwise recent CMake versions warn about deprecation of v3.10
dalcinl
force-pushed
the
fix-warnings
branch
2 times, most recently
from
ae6969c to
6dff2e8
Compare
|
@rdbisme CI should be good now, please approve the workflow runs. Note that I've updated pybind11 to its latest stable branch state. |
|
Thanks. I'd honestly remove the But we can do it in another PR. |
I can contribute the removal of |
|
@rdbisme I believe I can sneak in the removal of |
Do not use the C++ stdlib std::bind1st and std::mem_fun. These two APIs were deprecated in C++11 and removed in C++17.
…rator src/apps/mppshock.cpp:41:12: warning: explicitly defaulted copy assignment operator is implicitly deleted [-Wdefaulted-function-deleted] 41 | State& operator=( const State &) = default;
src/apps/bprime.cpp:62:15: warning: anonymous non-C-compatible type given
name for linkage purposes by typedef declaration; add a tag name here
[-Wnon-c-typedef-for-linkage]
|
Yep, sounds good to me. |
dalcinl
force-pushed
the
fix-warnings
branch
from
e8cef4e to
7a34e3c
Compare
|
@rdbisme This is ready to go, please merge at your earliest convenience. |
2 participants
Fix warnings with recent versions of CMake 3.31 / GCC 15.2 / clang 21.1 (Fedora 43).