Skip to content

Unvendor Eigen and bump to 3.4.1 #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dalcinl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Unvendor Eigen and bump to 3.4.1 #288

dalcinl wants to merge 2 commits into from

Conversation

@dalcinl
Copy link
Contributor

@dalcinl dalcinl commented Dec 14, 2025

  • Unvendor Eigen by removing thirdparty/eigen
  • Bump Eigen to 3.4.1 via CMake/FetchContent

@dalcinl
Copy link
Contributor Author

dalcinl commented Dec 14, 2025

@rdbisme What a great PR to bump my GitHub stats!

@dalcinl
Copy link
Contributor Author

dalcinl commented Dec 14, 2025 •
edited
Loading

A few comments about FetchContent and its relation to find_package.

  • For more recent CMake versions (>=3.14), the FetchContent approach interoperates with find_package. If Eigen is properly installed in the system, the system installation will be used.
  • For older CMake versions back to 3.14 (when FetchContent was added), the dependency is always fetched from git.

I bumped the CMake requirement to 3.15, one more than the strict minimum for FetchContent, to accommodate for scikit-build-core requirements . If we want to enforce FetchContent/find_package interoperability to always honor system installations, then we need to bump the CMake requirement to 3.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dalcinl