rebuilds subscriptions on consumer_cancel_notify #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of RabbitMQ's extensions to AMQP is to have a broker:
The documentation for the extension describes these "unexpected consumer cancellations" as:
The default behavior for both bunny and march_hare is to present support for this capability when connecting to RabbitMQ. Therefore, by default ActionSubscribers will receive basic.cancel signals when on the the scenarios described above occurs. Currently, when that happens, the ActionSubscriber will not attempt to resume consumption but rather will sit idle because no further messages will be sent from the broker on that channel. This change attempts to rebuild the subscription so consumption of messages will resume after the basic.cancel signal is received.