Skip to content

fix: forward request context and session in fault tolerance request filter #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattnichols wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: forward request context and session in fault tolerance request filter #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions gateway/src/main/java/com/mx/path/gateway/connect/filter/FaultTolerantRequestFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
import com.mx.path.core.common.http.HttpStatus;
import com.mx.path.core.common.process.FaultTolerantExecutor;
import com.mx.path.core.context.RequestContext;
import com.mx.path.core.context.ResponseContext;
import com.mx.path.core.context.Session;
import com.mx.path.core.context.facility.Facilities;
import com.mx.path.gateway.context.GatewayRequestContext;

Expand All @@ -21,8 +23,26 @@ public final void execute(Request request, Response response) {
FaultTolerantExecutor faultTolerantExecutor = Facilities.getFaultTolerantExecutor(RequestContext.current().getClientId());
if (faultTolerantExecutor != null) {
try {
RequestContext currentRequestContext = RequestContext.current();
ResponseContext currentResponseContext = ResponseContext.current();
Session currentSession = Session.current();

String scope = request.getFaultTolerantScope() != null ? request.getFaultTolerantScope() : buildScope();
faultTolerantExecutor.submit(scope, scopeConfigurations -> {

// Forward context objects to current thread.
if (currentRequestContext != null) {
currentRequestContext.register();
}

if (currentResponseContext != null) {
currentResponseContext.register();
}

if (currentSession != null) {
Session.setCurrent(currentSession);
}

// If a request timeout was explicitly provided (should be rare) we respect it. Otherwise, we use the timeout
// that the FaultTolerantExecutor is using for this request.
if (request.getRequestTimeOut() == null) {
Expand Down