Support Ubuntu 24 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for RHEL 7.x
Ubuntu 21.04 was released today, and currently this gem errors because it's not supported. I've installed wkhtmltopdf manually on my system using the binary for Focal Fossa (20.04) and it's working fine based on my testing.
Use the 20.04 binary for 21.04
…ntu_24 Add support to ubuntu 24.04
fix for linux mint 22
Add support for alibaba cloud linux
Fix binary used for Amazon Linux 2023 AMI
Add support for AlmaLinux 8
Update CHANGELOG for version 0.12.6.8
Update wkhtmltopdf: Support KDE Neon 22.04 and 24.04
Add support to ubuntu 22.04 and 24.04 in arm64
Update wkhtmltopdf to support Debian 13
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
patelvp
requested changes
Oct 24, 2025
| unless File.exist? binary | ||
| raise 'Invalid platform, must be running on Ubuntu 18.04/20.04/22.04, ' \ | ||
| 'CentOS 7, Amazon Linux 2, or intel-based Cocoa macOS ' \ | ||
| raise 'Invalid platform, must be running on Ubuntu 16.04/18.04/20.04/22.04, ' \ |
There was a problem hiding this comment.
Suggested change
| raise 'Invalid platform, must be running on Ubuntu 16.04/18.04/20.04/22.04, ' \ | |
| raise 'Invalid platform, must be running on Ubuntu 16.04/18.04/20.04/22.04/24.04, ' \ |
| os_based_on_ubuntu_20_04 = os.start_with?('ubuntu_20.') | ||
| os = 'ubuntu_20.04' if os_based_on_ubuntu_20_04 | ||
|
|
||
| os_based_on_ubuntu_22_04 = os.start_with?('ubuntu_22.') || os.start_with?('ubuntu_24.') |
There was a problem hiding this comment.
Suggested change
| os_based_on_ubuntu_22_04 = os.start_with?('ubuntu_22.') || os.start_with?('ubuntu_24.') | |
| os_based_on_ubuntu_22_04 = os.start_with?('ubuntu_22.') |
Why did we merge the condition here? Can we create a new line?
Author
There was a problem hiding this comment.
This matches the upstream logic, which uses the 22 binary for either 22 or 24. Refer: https://github.com/zakird/wkhtmltopdf_binary_gem/blob/master/bin/wkhtmltopdf#L45-L50
patelvp
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.