Skip to content

Conversation

@GravendeelJochem
Copy link
Contributor

INT-1309

@GravendeelJochem GravendeelJochem requested a review from a team as a code owner January 23, 2026 09:24
Copilot AI review requested due to automatic review settings January 23, 2026 09:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for priority delivery as a new shipment option across the application, including updates to models, validation, settings, and comprehensive test coverage.

Changes:

  • Added priority delivery shipment option with carrier settings and pricing
  • Updated all test snapshots to include the new priority delivery field
  • Integrated priority delivery into delivery options fees and validation

Reviewed changes

Copilot reviewed 177 out of 190 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/App/Options/Definition/PriorityDeliveryDefinition.php New definition class for priority delivery option
src/Shipment/Model/ShipmentOptions.php Added priorityDelivery constant and property
src/Settings/Model/CarrierSettings.php Added allow/price settings for priority delivery
src/Proposition/Model/PropositionCarrierFeatures.php Added priority delivery shipment option constant
src/Fulfilment/Model/ShipmentOptions.php Added priorityDelivery property to fulfilment model
src/Frontend/View/CarrierSettingsItemView.php Added UI settings fields for priority delivery
src/App/Service/DeliveryOptionsResetService.php Included priority delivery in reset service
src/App/DeliveryOptions/Service/DeliveryOptionsService.php Mapped priority delivery settings
src/App/DeliveryOptions/Service/DeliveryOptionsFeesService.php Added priority delivery to fee calculation
src/Validation/Validator/CarrierSchema.php Added validation method for priority delivery
config/pdk-business-logic.php Registered priority delivery definition
config/schema/order.json Added priority delivery to order schema
tests/Datasets/shipmentOptions.php Added priority delivery to test datasets and new helper function
Test snapshots Updated all JSON snapshots to include priorityDelivery field
Test files Updated test cases to include priority delivery

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.89%. Comparing base (a8e0a5f) to head (8feccf8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Validation/Validator/CarrierSchema.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #413      +/-   ##
============================================
- Coverage     94.91%   94.89%   -0.02%     
- Complexity     2032     2039       +7     
============================================
  Files           359      360       +1     
  Lines          6644     6664      +20     
============================================
+ Hits           6306     6324      +18     
- Misses          338      340       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Jan 23, 2026
@github-project-automation github-project-automation bot moved this from Todo to Testing in PDK Jan 27, 2026
@myparcel-bot myparcel-bot bot added the approved (Auto) label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved (Auto)

Development

Successfully merging this pull request may close these issues.

4 participants