-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add priority delivery #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for priority delivery as a new shipment option across the application, including updates to models, validation, settings, and comprehensive test coverage.
Changes:
- Added priority delivery shipment option with carrier settings and pricing
- Updated all test snapshots to include the new priority delivery field
- Integrated priority delivery into delivery options fees and validation
Reviewed changes
Copilot reviewed 177 out of 190 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/App/Options/Definition/PriorityDeliveryDefinition.php |
New definition class for priority delivery option |
src/Shipment/Model/ShipmentOptions.php |
Added priorityDelivery constant and property |
src/Settings/Model/CarrierSettings.php |
Added allow/price settings for priority delivery |
src/Proposition/Model/PropositionCarrierFeatures.php |
Added priority delivery shipment option constant |
src/Fulfilment/Model/ShipmentOptions.php |
Added priorityDelivery property to fulfilment model |
src/Frontend/View/CarrierSettingsItemView.php |
Added UI settings fields for priority delivery |
src/App/Service/DeliveryOptionsResetService.php |
Included priority delivery in reset service |
src/App/DeliveryOptions/Service/DeliveryOptionsService.php |
Mapped priority delivery settings |
src/App/DeliveryOptions/Service/DeliveryOptionsFeesService.php |
Added priority delivery to fee calculation |
src/Validation/Validator/CarrierSchema.php |
Added validation method for priority delivery |
config/pdk-business-logic.php |
Registered priority delivery definition |
config/schema/order.json |
Added priority delivery to order schema |
tests/Datasets/shipmentOptions.php |
Added priority delivery to test datasets and new helper function |
| Test snapshots | Updated all JSON snapshots to include priorityDelivery field |
| Test files | Updated test cases to include priority delivery |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
============================================
- Coverage 94.91% 94.89% -0.02%
- Complexity 2032 2039 +7
============================================
Files 359 360 +1
Lines 6644 6664 +20
============================================
+ Hits 6306 6324 +18
- Misses 338 340 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c9d0a38 to
b10de71
Compare
INT-1309