bug 119245: fix the detection logic of the 'INTO' keyword #121
Conversation
| private static final String[] ODKU_CLAUSE = new String[] { "ON", "DUPLICATE", "KEY", "UPDATE" }; | ||
| private static final String LAST_INSERT_ID_FUNC = "LAST_INSERT_ID"; | ||
| private static final String INTO_CLAUSE = "INTO"; | ||
| private static final String INTO_CLAUSE = " INTO "; |
There was a problem hiding this comment.
A regex would be nice but the whole comparing logic does not support that. Now '\nINTO ...' will be missed
MilovdZee
changed the title
MilovdZee
changed the title
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
signed. It is in review |
2 participants
It used to scan for 'INTO' but that fails on field names like 'MarginTotal' as that contain the sequence 'inTo'.
I did a lazy fix by searching for ' INTO '. So with two spaces. The code that checks strings is very deeply integrated and using a regex might be expensive.
This at least is better than before the previous bug.
See https://bugs.mysql.com/bug.php?id=119245
and 55f5db9#r168900828