fix invalid comparison causing errors opening frame#75
Open
partyfamine wants to merge 1 commit inton10v:mainfrom
Open
fix invalid comparison causing errors opening frame#75partyfamine wants to merge 1 commit inton10v:mainfrom
partyfamine wants to merge 1 commit inton10v:mainfrom
Conversation
Owner
|
Hey @partyfamine, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that after modifying tags in foobar2000 that
Open()would fail with the following error:frame went over tag areaThis was due to foobar2000 truncating the padding after the final frame and
Open()was reading the audio data as the next frame size. Theid == ""check should have caught this, but even though []byte{0, 0, 0, 0} will be printed as an empty string, it is not equivalent.