Support ipv6, dns-*, source and more hooks #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from yan12125
Removed silly reference to myself while still giving credit to yan12125 for his awesome work.
Fix bug - Append adapter if index is None
Owner
|
Many thanks ! |
|
@nMustaki Any plans to merge this or update this library? |
Owner
|
Hi @gaby yes that would be great, it's a nice PR ! I completly forgot about it and there are a lot of conflicts, but I'll try to merge it soon. |
Owner
|
@nMustaki I can take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @nMustaki here:
dggreenbaum#10 (comment)