wip cleanup synchronizers#1
Open
nimakaviani wants to merge 3 commits intonabuskey:feature/aws-dynamic-accountfrom
Open
wip cleanup synchronizers#1nimakaviani wants to merge 3 commits intonabuskey:feature/aws-dynamic-accountfrom
nimakaviani wants to merge 3 commits intonabuskey:feature/aws-dynamic-accountfrom
Conversation
Author
|
I will have an attempt in completely removing |
nabuskey
force-pushed
the
feature/aws-dynamic-account
branch
2 times, most recently
from
4c92048 to
2d78f5b
Compare
nabuskey
force-pushed
the
feature/aws-dynamic-account
branch
2 times, most recently
from
6266ddf to
3da6d8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
made the following changes
DefaultAmazonAccountsSynchronizerAmazonAccountsSynchronizerAmazonBasicCredentialsLoaderand other dependencies are relaxedCredentialsLoadercan also be removed but ECS provider depends on it