Support for running as an Unbound Python module#72
Open
JeremyRand wants to merge 6 commits intonamecoin:dns-devfrom
Open
Support for running as an Unbound Python module#72JeremyRand wants to merge 6 commits intonamecoin:dns-devfrom
JeremyRand wants to merge 6 commits intonamecoin:dns-devfrom
Conversation
…in a more central location.
…oduction-ready at all.
Member
Author
|
@phelixbtc I realize you can't test this since you're on Windows; should we merge this or wait for someone else to review? |
|
I think 'name == "main"' all over the place should be replaced by a variable to the init function (e.g. "def init(standalone=True)". Like this it will not work with nmcontrolwin.py edit: nitpick: missing CR at the end of files |
Member
Author
|
@phelixbtc Good feedback, I'll make those changes and get back to you. |
Member
Author
|
Upon talking to Hugo on IRC, I'm going to temporarily put this PR on hold. So don't merge at this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.