Skip to content

Fix various warnings/errors detected by PyLint#75

Open
JeremyRand wants to merge 6 commits intonamecoin:masterfrom
JeremyRand:pylint-fixes-1
Open

Fix various warnings/errors detected by PyLint#75
JeremyRand wants to merge 6 commits intonamecoin:masterfrom
JeremyRand:pylint-fixes-1

Conversation

@JeremyRand
Copy link
Member

One of the fixes was in platform-dependent code, someone please test to make sure it still boots without exceptions on Windows.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not remove this, it helps readability. As long as we don't remove this global we should at least be explicit about it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never write to app; PyLint therefore complains that we shouldn't declare it as a global, since the only reason to declare as a global is so that you can write to it. I don't think it makes things more readable either (and it makes the code less readable to PyLint).

@phelixbtc
Copy link

Why do you suggest to convert all the option dicts to lists?

@JeremyRand
Copy link
Member Author

@phelixbtc Khal's code was converting dicts to lists at run time (but also accepted lists verbatim); that makes it impossible for PyLint to do static analysis of that code to check for errors.

@phelixbtc
Copy link

FTFY: #83

@JeremyRand
Copy link
Member Author

Now that #83 is merged, I'll rebase this soon to not include that particular fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants