-
Notifications
You must be signed in to change notification settings - Fork 15
chore(namehash-ui): Copy shared components from ENSAdmin & ENSAwards #1507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 7ce853e The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
packages/namehash-ui/src/components/registrar-actions/RegistrarActionCard.tsx
Fixed
Show fixed
Hide fixed
…/feat/copy-components-to-namehashui
lightwalker-eth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Y3drk Nice updates 👍 Reviewed and shared feedback. Please feel welcome to take the lead to merge when ready. Thanks!
packages/namehash-ui/README.md
Outdated
| ``` | ||
|
|
||
| Note: `@ensnode/ensnode-react` is necessary only for some components. It might happen that you won't need it. | ||
| Note: `@ensnode/ensnode-react` is necessary only for some components. It might happen that you won't need it. Same goes for `sonner` it's only necessary for `CopyButton` component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is sonner only necessary for the CopyButton component? I assume this is for tooltips? Don't all our apps use tooltips and therefore don't all our apps require sonner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, these two are unrelated. I think sonner is much more similar to the pure JS alert feature than the tooltip. You can have a look at shadcn's sonner docs for more info.
Either way out of all shared components only the CopyButton uses the import { toast } from "sonner"; hence the information in the readme.
| "@ensnode/ensnode-sdk": "workspace:*", | ||
| "@radix-ui/react-avatar": "^1.1.10", | ||
| "@radix-ui/react-slot": "^1.2.3", | ||
| "@radix-ui/react-tooltip": "^1.2.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, so we need sonner on top of these other tooltip libraries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lightwalker-eth Yes, these are separate functionalities. (See these docs for more info).
lightwalker-eth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Y3drk Updates all look great. Thanks!
Substantial PR → Copy shared components from ENSAdmin & ENSAwards
Reviewer Focus (Read This First)
What reviewers should focus on
packages/namehash-ui/src/components/identity/ResolveAndDisplayIdentity.tsx:ResolveAndDisplayIdentityPropsandpackages/namehash-ui/src/components/registrar-actions/RegistrarActionCard.tsx. I suggest reasoning about the changes made, focusing on differences in how each of our apps displaysregistrar-actionsProblem & Motivation
Why this exists
Phase 3&Phase 4of the strategy suggested in the aforementioned Issue.What Changed (Concrete)
What actually changed
package.jsonandREADME.mdfiles accordingly.Design & Planning
How this approach was chosen
Phase 3&Phase 4Self-Review
What you caught yourself
packages/namehash-ui/src/components/identity/ResolveAndDisplayIdentity.tsx:ResolveAndDisplayIdentityPropsmight seem weird (the addition ofidentityLinkDetails), but with how our registrar actions display is designed across our apps, I found it the best way to keep the code usable across both of them without any design changes. Feel free to attack it.Cross-Codebase Alignment
ensawards,ensadmin, anddocs/ensrainbow.io.❌ move cancelled🔁 postponedDownstream & Consumer Impact
Who this affects and how
namehash-uiitself, this PR shouldn't affect any of our apps, docs, or packages.namehash-ui/README.meTesting Evidence
in actionas I apply the package in our apps in later PRs, as they seem finein codewhen I review them now.namehash-uipackage. I expect that nothing bad should happen, but even if it does, it won't affect any of our apps, as none of them use the package yet.Scope Reductions
🔁 postponedRisk Analysis
How this could go wrong
namehash-uipackagenamehash-uipackagePre-Review Checklist (Blocking)