-
Notifications
You must be signed in to change notification settings - Fork 2
fix(deps): update dependency next to v15.4.10 [security] #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ | |
| "@vercel/analytics": "1.3.1", | ||
| "@vercel/speed-insights": "1.0.12", | ||
| "classcat": "5.0.5", | ||
| "next": "14.2.35", | ||
| "next": "15.4.10", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Next.js was upgraded from 14.2.35 to 15.4.10, but View Details📝 Patch Detailsdiff --git a/apps/nameguard.io/package.json b/apps/nameguard.io/package.json
index b54aa48..99ed69e 100644
--- a/apps/nameguard.io/package.json
+++ b/apps/nameguard.io/package.json
@@ -30,7 +30,7 @@
"@types/react-dom": "18.3.1",
"autoprefixer": "10.4.20",
"eslint": "8.57.1",
- "eslint-config-next": "14.2.14",
+ "eslint-config-next": "15.4.10",
"postcss": "8.4.47",
"tailwind-scrollbar-hide": "1.1.7",
"tailwindcss": "3.4.13",
AnalysisESLint Config Version Mismatch in apps/nameguard.ioWhat fails: How to reproduce: # In a Next.js 15.4.10 project with eslint-config-next 14.2.14:
npm run lint # or next lint
# ESLint runs with configuration rules designed for Next.js 14.2, not 15.4Result: ESLint configuration rules are based on Next.js 14.2, missing newer rules and patterns introduced in Next.js 15.4 Expected: Per Next.js 15 upgrade guide, when upgrading Next.js, Additional context: This pattern was also identified and fixed in the Nx workspace generator (https://github.com/nrwl/nx/pull/30258), which had the same issue of installing Next.js 15 with eslint-config-next 14. The fix is to maintain version parity between the packages. |
||
| "react": "18.3.1", | ||
| "react-dom": "18.3.1", | ||
| "sharp": "0.33.5", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next.js was upgraded from 14.2.35 to 15.4.10, but
eslint-config-nextwas not updated from 14.2.14. These versions should be kept in sync to ensure ESLint uses the correct configuration rules for the Next.js version being used.View Details
📝 Patch Details
Analysis
ESLint configuration version mismatch with Next.js 15.4.10
What fails:
eslint-config-next@14.2.14provides ESLint rules tailored for Next.js 14.x, but Next.js has been upgraded to 15.4.10. This causes ESLint to miss Next.js 15-specific linting rules, allowing code that violates Next.js 15 best practices to pass linting.How to reproduce:
cd apps/namegraph.dev pnpm lintCurrent behavior: With eslint-config-next@14.2.14, the linter does not report an error on line 50 of
app/layout.tsxwhich uses an HTML<a>tag for navigation instead of Next.js<Link>component.Expected behavior: ESLint should enforce Next.js 15-specific rules from
@next/eslint-plugin-next@15.4.10. With the fix, running lint now correctly reports:Why this matters: The official Next.js 15 upgrade guide explicitly recommends updating
eslint-config-nextalongside Next.js, and this pattern has been identified as a bug by other projects (e.g., Nx issue #30257 with merged fix).Fix: Update
eslint-config-nextfrom 14.2.14 to 15.4.10 inapps/namegraph.dev/package.jsonto match the installed Next.js version.