Phases calculation using the Designmatrix feature #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhisrkckl
reviewed
Oct 24, 2024
Comment on lines
702
to
708
| parser.add_argument( | ||
| "--calc_phase", | ||
| help="Calculates the phase at each MCMC step using the designmatrix", | ||
| default=False, | ||
| action="store_true", | ||
| dest="calc_phase", | ||
| ) |
Contributor
There was a problem hiding this comment.
I suggest changing this option to "--linearize_model" or something like that. I don't think "--calc_phase" accurately reflects what it is doing.
src/pint/scripts/event_optimize.py
Outdated
| pos[0] = ftr.fitvals | ||
|
|
||
| # How phase will be calculated at each step (either with the designmatrix or ) | ||
| ftr.calc_phase = True if args.calc_phase else False |
Contributor
There was a problem hiding this comment.
This can just be ftr.calc_phase = args.calc_phase
Contributor
|
Please add a CHANGELOG entry |
Contributor
|
Shall I merge this? The changes look OK to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in a calculation that using the designmatrix to calculate the phases of each photon during each step of the MCMC run in
event_optimize. This leads to a dramatic speed up in the MCMC run.Here are some test runs I have done with real gamma-ray data. The samples line up well with the exception of the internal
PHASEparameter that is written into the fitter withinevent_optimize. This parameter is an internal parameter that serves as analogous to absolute phase and does not effect the timing model.