Provide physical formulas for magnetic field calculations. #1858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous formulas for the magnetic field at the polar cap and light cylinder relied on a single scale. I replaced them with physical versions involving the neutron star moment of inertia, radius, etc., and using an explicit conversion units conversion appropriate for the cgs system. I updated the tests to agree with the new (exact) implementation. A few other lines were munged by
black.