Fix WAVE_OM units #1861
Merged
Fix WAVE_OM units #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please add a changelog entry |
Contributor
Author
|
Done -- hopefully it's OK!
…On Fri, 15 Nov 2024 at 03:07, Abhimanyu Susobhanan ***@***.***> wrote:
Please add a changelog entry
—
Reply to this email directly, view it on GitHub
<#1861 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF3LAGYQTO6NZKWKM4JJLSL2AWTT5AVCNFSM6AAAAABRZPFJNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZYGE4DIMRUHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Shall I merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WAVE model was implemented some time ago, before the dust had settled on how to handle angular units. Consequently, the default unit for WAVE_OM was d^-1. However, it is an angular frequency, so the correct unit is u/d. This PR corrects the unit and some downstream code. I also added some tests. Admittedly the tests are still pretty sparse, but TAOSMHITD.