-
Notifications
You must be signed in to change notification settings - Fork 105
Use VLBI astrometric measurements along with coordinate system offset in the timing model #1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Example par file: The coordinate offsets are not fittable parameters since they cannot be determined from a single pulsar. |
src/pint/models/astrometry.py
Outdated
|
|
||
| def vlbi_coord_rotation(self) -> Optional[np.ndarray]: | ||
| """Returns the coordinate rotation matrix between VLBI and pulsar | ||
| timing coordinate systems if the rotation parameters are given.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be helpful to have a paper reference or a little more math to explain this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @dlakaplan and @abhisrkckl ! If you need a paper reference or a little more math, I'd recommend Wang et al.'s paper. That being said, the notation wasn't super intuitive when I read it so please let me know if I can help with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a reference to Madison et al, since I think that is the original paper where this equation is from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know if there is an older referecne I should use.
|
@mtlam : this looks good to me, but don't know if you have thoughts. |
|
I'm going to mostly defer to Sophia as the expert here. It looks like the goal is to allow for these kinds of offsets in simulated TOAs? |
|
The main aim here is simulations, and to allow VLBI measurements to be used directly in par files. Fitting for the coordinate offsets is not an aim, since that can't be done with single pulsars. |
If I understand correctly, this equation is used for estimating the coordinate offset. However, this PR is not doing that. It is only for simulating the offset, and for using the offset in a par file if it's already known. I am not adding the coordinate offset estimation part since it requires analyzing multiple pulsars together, and we had decided to keep PINT strictly single-pulsar to avoid overlapping functionalities with enterprise etc. |



This is based on https://arxiv.org/abs/2509.21203, mostly for simulation purposes.