Compatibility changes for Slurm 24.11#92
Merged
natefoo merged 3 commits intonatefoo:mainfrom Feb 14, 2025
Merged
Conversation
the errcode of the API call is being the return value (with SLURM_SUCCESS == no error) This is also present in in 24.05.X however slurm_get_errno() still exists.
Contributor
|
Nice! @natefoo any chance for a quick merge/release? I'm currently upgrading our cluster, but I can find a temp solution if you don't have the time |
Contributor
|
I had to make a few more changes to make it work on 24.11, I've pushed it in sandynomad#1 "Tested in Production©" 😬 |
|
We also plan to move on to 24.11 end of the month. |
Owner
|
Yeah I can get this in. @sandynomad do you want to accept @abretaud's PR? Looks good to me. |
More fixes for 24.11
Owner
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 24.11 slurm_get_errno() was removed as the errcode of the API call is being the return value (with SLURM_SUCCESS == no error).
This is also present in in 24.05.X however slurm_get_errno() still exists.