Skip to content

Conversation

@robertmclaws
Copy link

Implements #581

  • Created new ImplementationMetadataProvider framework
  • Moved current Reflection-based implementation to ReflectionMetadataProvider
  • Created new AOT-based MetadataProvider
  • Added a bunch of tests for both
  • Added sample AOT console application
  • Source generators are added to the existing package, should work for AOT without code changes

@natemcmaster
Copy link
Owner

Without having a close look yet myself…any hunches on why CI fails?

@robertmclaws
Copy link
Author

Probably because the build might need to be adjusted for the generators. AOT has additional requirements that might need to be installed for the build.

I'll take a look and drop another PR for the fix. But it should compile locally, and I can post the commands you need to make sure the right VC++ packages are installed on Windows to be able to run the AOT build.

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 85.81236% with 124 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.10%. Comparing base (812a157) to head (22cd721).

Files with missing lines Patch % Lines
...ils/SourceGeneration/ReflectionMetadataProvider.cs 92.08% 14 Missing and 5 partials ⚠️
...LineUtils/Conventions/OptionAttributeConvention.cs 90.18% 9 Missing and 7 partials ⚠️
src/CommandLineUtils/CommandLineApplication.cs 50.00% 9 Missing and 1 partial ⚠️
...ommandLineUtils/CommandLineApplicationWithModel.cs 0.00% 8 Missing ⚠️
...neUtils/Conventions/ArgumentAttributeConvention.cs 91.13% 5 Missing and 2 partials ⚠️
...ils/Conventions/RemainingArgsPropertyConvention.cs 53.84% 3 Missing and 3 partials ⚠️
...eUtils/SourceGeneration/CommandMetadataRegistry.cs 62.50% 5 Missing and 1 partial ⚠️
...Utils/Conventions/SubcommandAttributeConvention.cs 83.33% 3 Missing and 2 partials ⚠️
...Utils/Conventions/OptionAttributeConventionBase.cs 0.00% 4 Missing ⚠️
...dLineUtils/Conventions/ParentPropertyConvention.cs 50.00% 2 Missing and 2 partials ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   77.73%   76.10%   -1.64%     
==========================================
  Files         104      120      +16     
  Lines        3342     4017     +675     
  Branches      734      872     +138     
==========================================
+ Hits         2598     3057     +459     
- Misses        581      760     +179     
- Partials      163      200      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robertmclaws
Copy link
Author

Fixed the main build issue. Improving code coverage and working on getting the docs fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants