Skip to content

Comments

Fix integration gaps and add content overflow validation#1

Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix-integration-gaps-and-overflow
Draft

Fix integration gaps and add content overflow validation#1
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix-integration-gaps-and-overflow

Conversation

@google-labs-jules
Copy link
Contributor

This PR addresses 5 critical gaps identified in the code coverage assessment:

  1. Planner-Orchestrator Integration: Ensures ContentLayoutMatcher is correctly utilized by enriching the input JSON and allowing the orchestrator to respect content types (e.g., KPI vs bullets) assigned by the planner.
  2. Multi-Column Distribution: Adds logic in core_agents to rotate content types (bullets/KPI) for supporting placeholders, and ensures execution_orchestrator implements these choices.
  3. Subtopic Depth: Increases search queries from 1 to 3-5 per placeholder.
  4. Content Overflow: Implements a text measurement heuristic to detect overflow and trigger regeneration with fewer bullets.
  5. Hardcoded Fallbacks: Replaces hardcoded font sizes and colors with template-derived properties where possible.

PR created automatically by Jules for task 8794876467307216806 started by @nattu22

…low validation

- Update `core_agents.py` to generate multiple search queries per placeholder and ensure content type variety in supporting placeholders.
- Update `execution_orchestrator.py` to:
    - Enrich `slide_json` for `ContentLayoutMatcher` to better detect content types.
    - Respect content type assignments from the planner (core_agents) for proper multi-column distribution.
    - Add `_check_text_overflow` to regenerate content if it exceeds placeholder capacity.
    - Use template-based font sizes for subtitles instead of hardcoded fallbacks.
- Update `pptx_helper.py` to use theme colors for line fallback.
- Move imports to module level in `core_agents.py`.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants