FEAT: Add gat(get and touch) command to get item & update item expira… #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
uhm0311
requested changes
Aug 12, 2025
singsangssong
force-pushed
the
task/gat
branch
from
2ac1311 to
0e0257a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
uhm0311
previously approved these changes
Sep 9, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
singsangssong
force-pushed
the
task/gat
branch
from
0e0257a to
a73d95a
Compare
oliviarla
previously approved these changes
Sep 10, 2025
uhm0311
previously approved these changes
Sep 10, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
singsangssong
dismissed stale reviews from uhm0311 and oliviarla
via
cca3587
singsangssong
force-pushed
the
task/gat
branch
from
a73d95a to
cca3587
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Java 쪽 참고 사항현재 클라이언트에서는 여러 키에 대한 GAT 기능은 고려하지 않고 있으며, 단일 키에 대한 GAT만 지원하면 됩니다. 클라이언트 쪽 변경을 최소화하면서 구현하려고 했기 때문에, if (hasSwitchedOver(line)) {
prepareSwitchover(line);
return;
} |
Collaborator
|
NOT_MY_KEY 응답도 포함이죠? |
Contributor
|
NOT_MY_KEY 응답도 수신하고 있지만, 이는 기존 현재는 단일 키에 대해서만 |
uhm0311
requested changes
Dec 10, 2025
src/main/java/net/spy/memcached/protocol/ascii/BaseGetOpImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/spy/memcached/protocol/ascii/BaseGetOpImpl.java
Outdated
Show resolved
Hide resolved
oliviarla
reviewed
Dec 10, 2025
Collaborator
|
@singsangssong 리뷰 반영 부탁드립니다. |
singsangssong
force-pushed
the
task/gat
branch
5 times, most recently
from
c9de7ca to
2eafdd5
Compare
oliviarla
reviewed
Dec 19, 2025
src/main/java/net/spy/memcached/protocol/ascii/BaseGetOpImpl.java
Outdated
Show resolved
Hide resolved
singsangssong
force-pushed
the
task/gat
branch
2 times, most recently
from
e86aa2d to
ee6f59b
Compare
oliviarla
previously approved these changes
Dec 19, 2025
singsangssong
force-pushed
the
task/gat
branch
from
ee6f59b to
0de1ccd
Compare
jhpark816
previously approved these changes
Dec 19, 2025
Collaborator
|
@uhm0311 최종 리뷰 바랍니다. |
uhm0311
requested changes
Dec 19, 2025
| private final String cmd; | ||
| private final Collection<String> keys; | ||
| private String currentKey = null; | ||
| protected final int exp; |
Collaborator
There was a problem hiding this comment.
하위 클래스에서 직접 참조하는 부분이 이제 없으므로 private으로 선언합시다.
singsangssong
force-pushed
the
task/gat
branch
from
0de1ccd to
e1a76a4
Compare
uhm0311
approved these changes
Dec 19, 2025
Collaborator
|
@singsangssong |
Collaborator
|
@oliviarla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
memcached 서버의
gat를 java-client에도 추가합니다.이를 통해 expire time을 재설정 가능하도록 합니다.
Operation인터페이스 및 Ascii, Binary 프로토콜 구현체 추가OperationFactory에GetAndTouch추가MemcachedClient에 사용자가 호출할 수 있는gat기능 추가gat기능을 위한 테스트 코드 추가CI Test 실패 관련
현재 실패하고 있는 CI Test는
JDK 21, ubuntu-latest에서 Test ARCUS Client with ZK를 실패하고 있습니다.코드에서는
AsciiClientTest의gat관련 테스트를 실패하고 있습니다.해당 테스트는 현재 도커에 릴리즈된 memcached 서버는
gat기능이 아직 반영되지 않았기에, 테스트코드에서gat명령을 요청해도 응답이 없는 문제입니다.