Feature: :url data type validation for restricting URIs to http schema
#169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restrict URIs to HTTP/HTTPS - Enforce max length to be less than 2048 chars
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #169 +/- ##
===========================================
+ Coverage 87.69% 87.73% +0.04%
===========================================
Files 39 39
Lines 2739 2748 +9
===========================================
+ Hits 2402 2411 +9
Misses 337 337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Prefer `is_a?` over `kind_of?` throughout. - Rename predicate helpers: is_a_boolean?→boolean?, is_a_uri?→uri?, is_url?→url? - Mark helper predicates as `private`. - Remove unnecessary `self.` receivers in internal calls. - Flatten control flow in `enforce_type` with guard clauses. - Use `all?` instead of select/reject+empty? (short-circuit, fewer allocs). - Replace `a || b` with `[:uri, RDF::URI].include?(type)` to satisfy Style/MultipleComparison. - No functional changes; tests unchanged.
mdorf
added a commit
that referenced
this pull request
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: add
:urldata type (restrict to HTTP/HTTPS)What
:urlvalidator that accepts only absolute HTTP/HTTPS URLs with a non-empty host.:urisemantics unchanged.Why
:uriis intentionally broad (e.g., acceptsmailto:…,file:///…, etc.).Some attributes (e.g.,
pullLocation,documentation,publication) are rendered as links or used for remote fetches and should be limited to HTTP/HTTPS.Scope
Non-goals
Comprehensive SSRF protection (DNS/IP checks, private network blocking, allow/deny lists) — to be handled higher in the stack to keep core data validation lightweight.
see:
:urlValidator to Enforce HTTP/HTTPS URI Schemes Only #164