feat: set header rtl styles#10
Closed
andrey-canon wants to merge 1 commit intoopen-release/teak.nelpfrom
Closed
Conversation
andrey-canon
force-pushed
the
and/set-header-rtl-styles
branch
from
c2c22b3 to
15e6377
Compare
johanseto
approved these changes
Jan 22, 2026
johanseto
left a comment
johanseto
left a comment
There was a problem hiding this comment.
Working in my local env.
Something interesting is that without paragon and conditional user fields. Learner dashboard works as expected in the after image.
So to replicate, I had to configure those settings.
Screencast.from.22-01-26.08.26.44.webm
Collaborator
Author
|
Thanks @johanseto. Your findings helped me realize how the MFE behaves: it loads the default Paragon styles and then uses postcss-rtlcss to generate valid RTL CSS based on the original styles. Based on this, I applied the same process to generate a new default styles file, so this PR is no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set the rtl styles for learning header and site desktop header
Before (learning header)
Before (desktop header)
After (learning header)
After (desktop header)