feat: add option to add nonce to style-src directive#81
Open
codepunkt wants to merge 5 commits intonetlify:mainfrom
Open
feat: add option to add nonce to style-src directive#81codepunkt wants to merge 5 commits intonetlify:mainfrom
style-src directive#81codepunkt wants to merge 5 commits intonetlify:mainfrom
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 0c88410 |
codepunkt
changed the title
style-src directivestyle-src directive
|
Wondering why this hasn't been merged? Missing the nonce option for style-src is a valuable addition for this. |
|
Bump? Having style-src is definitely needed. |
Contributor
|
Apologies for not seeing this sooner, we ended up moving the actual csp logic into a library which the plugin and extension make use of - the style-src work would need to land in that library and then we could update the library version used in this plugin -- https://github.com/netlify/csp_nonce_html_transformer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the option to add the generated nonce to the
style-srcdirective and add the nonce attribute to style-related elements.Let me know what you think!