stats: simplify statistics implementation #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 11, 2025 09:21
Each worker thread has its own counter struct and updates it independently. The telemetry thread can read the counter struct from any worker at any time because we assume that updates (to uint64_t) are atomic. Reading the counter struct should not cause an invalidation of the worker's cache.
fstreun
force-pushed
the
fstreun/stats-rework
branch
from
08b59d4 to
9f2b765
Compare
added 2 commits
January 11, 2025 17:39
Only account them once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each worker thread has its own statistics struct and updates the counters in it independently. The telemetry thread can read the counters from any worker at any time. We assume that updates (to uint64_t) are atomic. Reading the counters should not cause an invalidation of the worker's cache.
This change is