Skip to content

Update endpoint and remove httpauth #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kintamahadji wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update endpoint and remove httpauth #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f61cf8
Update BasecampClient.php
kintamahadji Jan 25, 2022
351d255
Update BasecampClient.php
kintamahadji Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions src/Basecamp/BasecampClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,29 +26,19 @@ class BasecampClient extends Client
public static function factory($config = array())
{
$default = array(
'base_url' => 'https://basecamp.com/{user_id}/api/{version}/',
'version' => 'v1',
'auth' => 'http',
'base_url' => 'https://3.basecampapi.com/{user_id}/',
'token' => null,
'username' => null,
'password' => null,
);
$required = array('user_id', 'app_name', 'app_contact');
$config = Collection::fromConfig($config, $default, $required);
$client = new self($config->get('base_url'), $config);

if ($config['auth'] === 'http') {
if (! isset($config['username'], $config['password'])) {
throw new InvalidArgumentException("Config must contain username and password when using http auth");
}
$authorization = 'Basic ' . base64_encode($config['username'] . ':' . $config['password']);
}
if ($config['auth'] === 'oauth') {
if (! isset($config['token'])) {
throw new InvalidArgumentException("Config must contain token when using oauth");
}
$authorization = sprintf('Bearer %s', $config['token']);

if (! isset($config['token'])) {
throw new InvalidArgumentException("Config must contain token when using oauth");
}
$authorization = sprintf('Bearer %s', $config['token']);

if (! isset($authorization)) {
throw new InvalidArgumentException("Config must contain valid authentication method");
}
Expand Down