-
Notifications
You must be signed in to change notification settings - Fork 7
WIP - Move server version management logic into its own file #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Ok, you should hold up a minute. I have a bunch of changes incoming for async/await goodness 😃 I'll get it finished up probably tomorrow and then I'll try to merge some of these in. |
|
Sorry :D This is currently the only one that is ready for review, the other ones are still WIP |
|
I did some fixes and added proper tests By the way, the reason I use |
|
During my experiments with NPM module testing, the But I understand the static property stuff too... we'll have to see how we can get this sorted another way. |
|
The solution might be to use |
Currently doesn't do much, but store the manifest url
Also adds the static property `Manifest.types`
Uses `nock` for mocking network tests
Might aswell while we're here
See commit messages for some details.
Also adds hash checking of downloaded file
This is what I meant by removing console spam in #45.
console.log()messages could be added when these operations start and end in the functions that call them, rather than in the functions themselves