Skip to content

Conversation

@architekture
Copy link
Collaborator

  • Added base ADVA ConfigParser class and two subclasses (FSP150F2, FSP150F3)
  • Added compliance and parser testing suites, tests are successful

@itdependsnetworks
Copy link
Contributor

Can you link to the vendor this is referencing? also, not normal for us to have separation of subclasses such as FSP150F2, FSP150F3, may make sense but should have context as to the why.

@jeffkala
Copy link
Collaborator

jeffkala commented Dec 16, 2025

Can you link to the vendor this is referencing? also, not normal for us to have separation of subclasses such as FSP150F2, FSP150F3, may make sense but should have context as to the why.

This was my request because f2 and f3 have many differences and we don't know them all "yet". Also Netmiko has two different drivers for f2 and f3 so we wanted to follow suite on that front. Netmiko drivers: https://github.com/ktbyers/netmiko/blob/develop/PLATFORMS.md#:~:text=adva_fsp150f2,adva_fsp150f3

@architekture
Copy link
Collaborator Author

Corrected issues with documentation and formatting. All checks green.

Copy link
Collaborator

@jeffkala jeffkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggested change to change fragment.

@@ -0,0 +1 @@
Parsing ADVA AOS device configs for compliance. FSP150F2 and FSP150F3 map to discrete Netmiko drivers and support different hardware generations. No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Parsing ADVA AOS device configs for compliance. FSP150F2 and FSP150F3 map to discrete Netmiko drivers and support different hardware generations.
Added parsing for FSP150F2 and FSP150F3 ADVA AOS device configs.

@itdependsnetworks
Copy link
Contributor

Please hold off on this one until I can get a look

@itdependsnetworks
Copy link
Contributor

To start, it's not clear to me what vendor this is?? Is this adtran?

@jeffkala
Copy link
Collaborator

To start, it's not clear to me what vendor this is?? Is this adtran?

ADTRAN Holdings acquired ADVA Optical Networking, these are still using Adva OS so are a different OS vs Adtran which has its own netmiko driver etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants